fix(TMC-28581): UI Form display fix with hint and required asterisk #5319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Size Change: +2.74 kB (0%) Total Size: 17.4 MB
ℹ️ View Unchanged
|
yyanwang
approved these changes
May 29, 2024
jmfrancois
reviewed
May 29, 2024
| {title} | ||
| {required && '*'} |
There was a problem hiding this comment.
I prefer if you can use a classic css approach.
Here you can't for example make it red
.required label:after {
color: #e32;
content: ' *';
display:inline;
}
There was a problem hiding this comment.
Ok good point
I could also change it on design system side , the idea was to have the same behavior
aamalric-talend
approved these changes
May 29, 2024
Gbacc
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
UI Form display fix with hint and required asterisk
What is the chosen solution to this problem?
Please check if the PR fulfills these requirements
yarn changesetto a request a release from the CI if wanted.[ ] This PR introduces a breaking change