feat(components/sidepanel): accept custom action ids #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabballe
approved these changes
Nov 13, 2017
acateland
approved these changes
Nov 14, 2017
| action.id || | ||
| action.label | ||
| .toLowerCase() | ||
| .split(' ') |
There was a problem hiding this comment.
a regexp could be used here but i guess it is a lot more readable the way you did it
talend-glorieux
suggested changes
Nov 14, 2017
| action.label | ||
| .toLowerCase() | ||
| .split(' ') | ||
| .join('-'); |
There was a problem hiding this comment.
Please move this to an actionId generator.
jsomsanith-tlnd
previously requested changes
Nov 14, 2017
1 similar comment
talend-glorieux
approved these changes
Nov 15, 2017
frassinier
deleted the
ncomont/feat/components/accept_custom_action_ids
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
Actions ids are base on the action's label. It cause problems with i18n (for example TDP onboarding uses theses IDs to target elements).
What is the chosen solution to this problem?
Actions can have a new
idproperty.Please check if the PR fulfills these requirements
[x] This PR introduces a breaking change
Before this, action ids were ignored. Now, if an id is provided per action, it will be used instead of the label ; so it could break some QA tests.