chore: upgrade react-jsonschema-form #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
jare-talend
approved these changes
May 18, 2018
|
publish as 0.186.0-beta-1 |
jmfrancois
approved these changes
May 21, 2018
jsomsanith-tlnd
deleted the
jsomsanith/chore/upgrade_react_jsonschema_form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
Split react 16 branch changes into smaller PRs, to ease the changes and the integration.
This PR only on upgrading react-jsonSchema-form lib.
What is the chosen solution to this problem?
Upgrade react-jsonschema-form
Please check if the PR fulfills these requirements
[x] This PR introduces a breaking change
There is breaking change because it uses ajv now to validate the schema. 2 format was supported to declare that a field is required.
Json schema spec says that the required format is the one the lib still support : http://json-schema.org/latest/json-schema-validation.html#rfc.section.6.5.3
Before
{ "jsonSchema": { "title": "Form with live validation", "type": "object", "properties": { "name": { "title": "Name", "type": "string", "minLength": 3, "required": true }, "email": { "title": "Email", "type": "string", "pattern": "^\\S+@\\S+$", "minLength": 5, "required": true } } } }After
{ "jsonSchema": { "title": "Form with live validation", "type": "object", "required": ["name", "email"], "properties": { "name": { "title": "Name", "type": "string", "minLength": 3 }, "email": { "title": "Email", "type": "string", "pattern": "^\\S+@\\S+$", "minLength": 5 } } } }