Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/events/followers.js references /beastie-functions.js but does not require it #4

Closed
scryptonite opened this issue May 16, 2017 · 0 comments · Fixed by #3
Closed

/events/followers.js references /beastie-functions.js but does not require it #4

scryptonite opened this issue May 16, 2017 · 0 comments · Fixed by #3

Comments

@scryptonite
Copy link
Collaborator

scryptonite commented May 16, 2017

/events/followers.js references beastieFunctions (/beastie-functions.js), but it is not require it. Additionally it seems the .queryTwitchAPI(queryUrl) export in beastie-functions.js is not syntactically correct JavaScript; pretty sure it was meant to be something along these lines:

module.exports.queryTwitchAPI = function (queryUrl){
  return {
    url: "https://api.twitch.tv/kraken/" + queryUrl,
    headers: {
      "Accept": "application/vnd.twitchtv.v5+json",
      "Authorization": "OAuth " + secrets.broadcaster.password,
      "Client-ID": secrets.clientId
    }
  };
}

I'll submit a PR for both asap 👌
Fixed in PR #3, commit 3353f4e. 👍

scryptonite referenced this issue in scryptonite/BeastieBot-Legacy-V1 May 16, 2017
Fixes Issue #4 and also stops Beastie from joining the teamTALIMA
channel by default unless that is the configured broadcaster's username
in /config/secrets.js
scryptonite added a commit that referenced this issue Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant