Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contrasts and overall state visibility #149

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Conversation

jpeltzi
Copy link
Contributor

@jpeltzi jpeltzi commented Aug 8, 2023

The default ripple effect of MUI is considered too subtle as focus highlighting.
Replacing with high-contrast, outline-based highlighting style.
Improving contrasts overall.
Closes #94
Closes #93

Replace the default MUI focus highlight ripple effect and replace with a more widely recognized and clear outline based style
@jpeltzi jpeltzi marked this pull request as draft August 8, 2023 09:20
@jpeltzi jpeltzi marked this pull request as ready for review August 8, 2023 13:34
@jpeltzi jpeltzi changed the title Replace ripple effects with conventional focus highlight Improve contrasts and overall state visibility Aug 9, 2023
Copy link
Contributor

@jlaamanen jlaamanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆

@ossitammi ossitammi merged commit 8835296 into develop Aug 11, 2023
2 checks passed
@ossitammi ossitammi deleted the a11y/full-revision branch January 26, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.2: Puutteellinen näkyvä kohdistus 2.2: Heikkoja kontrasteja
3 participants