Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): Replace forEach loop with for/of #86

Merged
merged 1 commit into from
May 13, 2024

Conversation

lachlancollins
Copy link
Member

I fall for this async problem every time...

#85 did not remove the scripts section. By replacing the async forEach loops with for...of loops, execution order should be fixed (🤞)

I fall for this async problem every damn time...
Copy link

nx-cloud bot commented May 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f6a45b3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@lachlancollins lachlancollins merged commit d44d223 into main May 13, 2024
2 checks passed
@lachlancollins lachlancollins deleted the foreach-vs-for-of branch May 13, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant