Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onSubmit usage #440

Merged
merged 10 commits into from
Sep 7, 2023
Merged

Fix onSubmit usage #440

merged 10 commits into from
Sep 7, 2023

Conversation

crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Sep 4, 2023 •
edited
Loading

This PR:

  • Fixes an issue where useForm would reset values on re-render
  • Migrates useEffects to be useIsomophicLayoutEffect so they run closer to when they might be expected to
  • Changes the quick-start guide to reflect changes

Fixes #437

This was referenced Sep 4, 2023
Closed
Closed
@crutchcorn crutchcorn marked this pull request as draft September 7, 2023 02:25
@crutchcorn crutchcorn marked this pull request as ready for review September 7, 2023 02:31
@crutchcorn crutchcorn merged commit 6f76fee into main Sep 7, 2023
5 of 6 checks passed
@crutchcorn crutchcorn deleted the fix-onsubmit branch September 7, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannerlinsley tannerlinsley Awaiting requested review from tannerlinsley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Since v0.0.15, FieldApi reflects Field values but not FormApi
1 participant
@crutchcorn