Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings v2 #454

Merged
merged 14 commits into from
Sep 9, 2023
Merged

Typings v2 #454

merged 14 commits into from
Sep 9, 2023

Conversation

crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Sep 8, 2023

This PR:

  • Removes the index field and the concept of sub-fields temporarily until we can revisit and provide more dedicated attention to docs/tests/API improvements due to typing complexity
  • Added back index field and sub-fields as they were implemented previously without new tests
  • Fixes React and Vue's typings to be much more strict and avoid never being the type of field.state.value
  • Adds type tests for React adapter to verify this fix

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 8, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Changed Coverage
packages/form-core/src/FieldApi.ts 100.00%
packages/react-form/src/useField.tsx 100.00%
packages/react-form/src/useForm.tsx 100.00%

📢 Thoughts on this report? Let us know!.

@crutchcorn crutchcorn merged commit 160f712 into main Sep 9, 2023
5 of 6 checks passed
@crutchcorn crutchcorn deleted the typings-v2 branch September 9, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants