Update PropTypes and createClass. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thchia Long term, this should use standard Javascript classes, as the browser warning notes. @tannerlinsley I don't know if you have a plan to migrate to that. |
|
@codinronan Yup you're right. I don't have the time to rewrite using the standard classes, this PR is just to smooth the transition. |
|
I plan on rewriting to es6 classes as soon as possible. But this looks good for the interim. |
Qrysto
added a commit
to Qrysto/react-form
that referenced
this pull request
May 8, 2017
* commit 'bb384e6d88eec36d80a0087c6076cd159461d48d': Update PropTypes and createClass. (TanStack#55) update docs to use built in radiogroup component, fixes TanStack#31 minor grammar update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick and dirty fix for #54 to prevent console errors, but not sure what future support plans for the create-react-class library are.