fix(types): make sure queryClient.setQueriesData can return undefined…

… from the updater (#3657)
TanStack · May 30, 2022 · 0c04e7d · 0c04e7d
1 parent 4a43068
commit 0c04e7d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/core/queryClient.ts b/src/core/queryClient.ts
@@ -148,19 +148,19 @@ export class QueryClient {
 
   setQueriesData<TData>(
     queryKey: QueryKey,
-    updater: Updater<TData | undefined, TData>,
+    updater: Updater<TData | undefined, TData | undefined>,
     options?: SetDataOptions
-  ): [QueryKey, TData][]
+  ): [QueryKey, TData | undefined][]
 
   setQueriesData<TData>(
     filters: QueryFilters,
-    updater: Updater<TData | undefined, TData>,
+    updater: Updater<TData | undefined, TData | undefined>,
     options?: SetDataOptions
-  ): [QueryKey, TData][]
+  ): [QueryKey, TData | undefined][]
 
   setQueriesData<TData>(
     queryKeyOrFilters: QueryKey | QueryFilters,
-    updater: Updater<TData | undefined, TData>,
+    updater: Updater<TData | undefined, TData | undefined>,
     options?: SetDataOptions
   ): [QueryKey, TData | undefined][] {
     return notifyManager.batch(() =>

diff --git a/src/core/tests/queryClient.test.tsx b/src/core/tests/queryClient.test.tsx
@@ -386,9 +386,8 @@ describe('queryClient', () => {
       queryClient.setQueryData(['key', 1], 1)
       queryClient.setQueryData(['key', 2], 2)
 
-      const result = queryClient.setQueriesData<number>(
-        ['key'],
-        old => old! + 5
+      const result = queryClient.setQueriesData<number>(['key'], old =>
+        old ? old + 5 : undefined
       )
 
       expect(result).toEqual([