fix(eslint-plugin-query): test for FunctionExpression syntax (#7213)

TanStack · Apr 2, 2024 · 1e3f791 · 1e3f791
1 parent a9648ba
commit 1e3f791
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/packages/eslint-plugin-query/src/__tests__/exhaustive-deps.test.ts b/packages/eslint-plugin-query/src/__tests__/exhaustive-deps.test.ts
@@ -726,5 +726,24 @@ ruleTester.run('exhaustive-deps', rule, {
         },
       ],
     },
+    {
+      name: 'should fail if queryFn is invalid while using FunctionExpression syntax',
+      code: normalizeIndent`
+        const id = 1;
+    
+        useQuery({
+            queryKey: [],
+            queryFn() {
+              Promise.resolve(id)
+            }
+        })
+      `,
+      errors: [
+        {
+          messageId: 'missingDeps',
+          data: { deps: 'id' },
+        },
+      ],
+    },
   ],
 })
diff --git a/packages/eslint-plugin-query/src/rules/exhaustive-deps/exhaustive-deps.rule.ts b/packages/eslint-plugin-query/src/rules/exhaustive-deps/exhaustive-deps.rule.ts
@@ -55,7 +55,10 @@ export const rule = createRule({
           scopeManager === null ||
           queryKey === undefined ||
           queryFn === undefined ||
-          queryFn.value.type !== AST_NODE_TYPES.ArrowFunctionExpression
+          !ASTUtils.isNodeOfOneOf(queryFn.value, [
+            AST_NODE_TYPES.ArrowFunctionExpression,
+            AST_NODE_TYPES.FunctionExpression,
+          ])
         ) {
           return
         }