fix(queryClient): make sure that setQueryData can return undefined fr…

…om the updater function on type level (#3615) the only runtime tests we had didn't use the previous value, so the generic defaults to unknown; the TS error becomes apparent when providing a generic to setQueryData
TanStack · May 14, 2022 · 35a40ec · 35a40ec
1 parent 0085137
commit 35a40ec
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/core/queryClient.ts b/src/core/queryClient.ts
@@ -128,7 +128,7 @@ export class QueryClient {
 
   setQueryData<TData>(
     queryKey: QueryKey,
-    updater: Updater<TData | undefined, TData> | undefined,
+    updater: Updater<TData | undefined, TData | undefined>,
     options?: SetDataOptions
   ): TData | undefined {
     const query = this.queryCache.find<TData>(queryKey)

diff --git a/src/core/tests/queryClient.test.tsx b/src/core/tests/queryClient.test.tsx
@@ -311,8 +311,8 @@ describe('queryClient', () => {
 
     test('should not update query data if updater returns undefined', () => {
       const key = queryKey()
-      queryClient.setQueryData(key, 'qux')
-      queryClient.setQueryData(key, () => undefined)
+      queryClient.setQueryData<string>(key, 'qux')
+      queryClient.setQueryData<string>(key, () => undefined)
       expect(queryClient.getQueryData(key)).toBe('qux')
     })