feat(svelte-query): Switch to moduleResolution bundler (#5471)

TanStack · May 26, 2023 · 3d385ff · 3d385ff
1 parent 3941ee1
commit 3d385ff
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 18 deletions.
diff --git a/packages/svelte-query-devtools/tsconfig.json b/packages/svelte-query-devtools/tsconfig.json
@@ -1,26 +1,24 @@
 {
   "compilerOptions": {
+    "allowImportingTsExtensions": true,
     "allowJs": true,
     "allowSyntheticDefaultImports": true,
     "checkJs": true,
     "esModuleInterop": true,
     "forceConsistentCasingInFileNames": true,
     "isolatedModules": true,
     "lib": ["esnext", "DOM", "DOM.Iterable"],
-    "moduleResolution": "node",
+    "moduleResolution": "bundler",
     "module": "esnext",
     "noEmit": true,
-    "noImplicitAny": true,
     "noImplicitReturns": true,
-    "noImplicitThis": true,
     "noUncheckedIndexedAccess": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "resolveJsonModule": true,
     "skipLibCheck": true,
     "sourceMap": true,
     "strict": true,
-    "strictNullChecks": true,
     "target": "esnext"
   },
   "include": ["src/**/*.js", "src/**/*.ts", "src/**/*.svelte", ".eslintrc.cjs", "vite.config.ts"]

diff --git a/packages/svelte-query-devtools/vite.config.ts b/packages/svelte-query-devtools/vite.config.ts
@@ -1,14 +1,14 @@
+import { resolve } from 'node:path';
 import { svelte } from '@sveltejs/vite-plugin-svelte';
-import path from 'path';
 import { defineConfig } from 'vite';
 
 export default defineConfig({
   plugins: [svelte()],
   resolve: {
     alias: {
-      "@tanstack/query-core": path.resolve(__dirname, '..', 'query-core', 'src'),
-      "@tanstack/query-devtools": path.resolve(__dirname, '..', 'query-devtools', 'src'),
-      "@tanstack/svelte-query": path.resolve(__dirname, '..', 'svelte-query', 'src'),
+      "@tanstack/query-core": resolve(__dirname, '..', 'query-core', 'src'),
+      "@tanstack/query-devtools": resolve(__dirname, '..', 'query-devtools', 'src'),
+      "@tanstack/svelte-query": resolve(__dirname, '..', 'svelte-query', 'src'),
     }
   }
 });
diff --git a/packages/svelte-query/src/createBaseQuery.ts b/packages/svelte-query/src/createBaseQuery.ts
@@ -1,8 +1,8 @@
-import type { QueryClient, QueryKey, QueryObserver } from '@tanstack/query-core'
+import { derived, get, readable, writable } from 'svelte/store'
 import { notifyManager } from '@tanstack/query-core'
+import type { QueryClient, QueryKey, QueryObserver } from '@tanstack/query-core'
 import type { CreateBaseQueryOptions, CreateBaseQueryResult } from './types'
 import { useQueryClient } from './useQueryClient'
-import { derived, get, readable, writable } from 'svelte/store'
 import { isWritable } from './utils'
 
 export function createBaseQuery<

diff --git a/packages/svelte-query/src/createQueries.ts b/packages/svelte-query/src/createQueries.ts
@@ -8,10 +8,8 @@ import type {
   QueriesObserverOptions,
   QueryObserverOptions,
 } from '@tanstack/query-core'
-
 import { notifyManager, QueriesObserver } from '@tanstack/query-core'
 import { derived, get, readable, writable, type Readable } from 'svelte/store'
-
 import type { WritableOrVal } from './types'
 import { useQueryClient } from './useQueryClient'
 import { isWritable } from './utils'

diff --git a/packages/svelte-query/tsconfig.json b/packages/svelte-query/tsconfig.json
@@ -1,26 +1,24 @@
 {
   "compilerOptions": {
+    "allowImportingTsExtensions": true,
     "allowJs": true,
     "allowSyntheticDefaultImports": true,
     "checkJs": true,
     "esModuleInterop": true,
     "forceConsistentCasingInFileNames": true,
     "isolatedModules": true,
     "lib": ["esnext", "DOM", "DOM.Iterable"],
-    "moduleResolution": "node",
+    "moduleResolution": "bundler",
     "module": "esnext",
     "noEmit": true,
-    "noImplicitAny": true,
     "noImplicitReturns": true,
-    "noImplicitThis": true,
     "noUncheckedIndexedAccess": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "resolveJsonModule": true,
     "skipLibCheck": true,
     "sourceMap": true,
     "strict": true,
-    "strictNullChecks": true,
     "target": "esnext",
     "types": ["vitest/globals", "@testing-library/jest-dom"]
   },

diff --git a/packages/svelte-query/vite.config.ts b/packages/svelte-query/vite.config.ts
@@ -1,12 +1,12 @@
+import { resolve } from 'node:path';
 import { svelte } from '@sveltejs/vite-plugin-svelte';
-import path from 'path';
 import { defineConfig } from 'vite';
 
 export default defineConfig({
   plugins: [svelte()],
   resolve: {
     alias: {
-      "@tanstack/query-core": path.resolve(__dirname, '..', 'query-core', 'src'),
+      "@tanstack/query-core": resolve(__dirname, '..', 'query-core', 'src'),
     }
   },
   test: {