chore: More eslint improvements (#5482)

TanStack · May 28, 2023 · 49e9c16 · 49e9c16
1 parent f9dce35
commit 49e9c16
Show file tree

Hide file tree

Showing 37 changed files with 85 additions and 302 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -8,6 +8,7 @@ module.exports = {
   extends: [
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
+    'plugin:import/recommended',
     'plugin:import/typescript',
     'prettier',
   ],
@@ -46,7 +47,10 @@ module.exports = {
     '@typescript-eslint/no-inferrable-types': [
       'error', { ignoreParameters: true },
     ],
+    'import/default': 'off',
+    'import/export': 'off',
     'import/no-cycle': 'error',
+    'import/no-duplicates': 'off',
     'import/no-unresolved': ['error', { ignore: ['^@tanstack/'] }],
     'import/no-unused-modules': ['off', { unusedExports: true }],
     'no-redeclare': 'off',

diff --git a/examples/react/algolia/.eslintrc b/examples/react/algolia/.eslintrc
@@ -1,7 +1,7 @@
 {
-  "extends": ["react-app", "prettier", "plugin:@tanstack/eslint-plugin-query/recommended"],
-  "rules": {
-    "react/jsx-uses-react": "off",
-    "react/react-in-jsx-scope": "off"
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended",
+    "plugin:@tanstack/eslint-plugin-query/recommended"
+  ]
 }
diff --git a/examples/react/basic-graphql-request/.eslintrc b/examples/react/basic-graphql-request/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/basic-typescript/.eslintrc b/examples/react/basic-typescript/.eslintrc
@@ -1,3 +1,7 @@
 {
-  "extends": ["react-app", "prettier", "plugin:@tanstack/eslint-plugin-query/recommended"]
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended",
+    "plugin:@tanstack/eslint-plugin-query/recommended"
+  ]
 }
diff --git a/examples/react/basic/.eslintrc b/examples/react/basic/.eslintrc
@@ -1,3 +1,7 @@
 {
-  "extends": ["react-app", "prettier", "plugin:@tanstack/eslint-plugin-query/recommended"]
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended",
+    "plugin:@tanstack/eslint-plugin-query/recommended"
+  ]
 }
diff --git a/examples/react/default-query-function/.eslintrc b/examples/react/default-query-function/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/offline/.eslintrc b/examples/react/offline/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/playground/.eslintrc b/examples/react/playground/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/react-router/.eslintrc b/examples/react/react-router/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/rick-morty/.eslintrc b/examples/react/rick-morty/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/simple/.eslintrc b/examples/react/simple/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/star-wars/.eslintrc b/examples/react/star-wars/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/react/suspense/.eslintrc b/examples/react/suspense/.eslintrc
@@ -1,7 +1,6 @@
 {
-  "extends": ["react-app", "prettier"],
-  "rules": {
-    // "eqeqeq": 0,
-    // "jsx-a11y/anchor-is-valid": 0
-  }
+  "extends": [
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended"
+  ]
 }
diff --git a/examples/solid/basic-graphql-request/.eslintrc b/examples/solid/basic-graphql-request/.eslintrc
@@ -1,10 +1,5 @@
 {
   "parserOptions": {
-    "project": "./tsconfig.json",
-    "sourceType": "module"
-  },
-  "rules": {
-    "react/react-in-jsx-scope": "off",
-    "jsx-a11y/anchor-is-valid": "off"
+    "project": "./tsconfig.json"
   }
 }
diff --git a/examples/solid/basic-typescript/.eslintrc b/examples/solid/basic-typescript/.eslintrc
@@ -1,10 +1,5 @@
 {
   "parserOptions": {
-    "project": "./tsconfig.json",
-    "sourceType": "module"
-  },
-  "rules": {
-    "react/react-in-jsx-scope": "off",
-    "jsx-a11y/anchor-is-valid": "off"
+    "project": "./tsconfig.json"
   }
 }
diff --git a/examples/solid/default-query-function/.eslintrc b/examples/solid/default-query-function/.eslintrc
@@ -1,10 +1,5 @@
 {
   "parserOptions": {
-    "project": "./tsconfig.json",
-    "sourceType": "module"
-  },
-  "rules": {
-    "react/react-in-jsx-scope": "off",
-    "jsx-a11y/anchor-is-valid": "off"
+    "project": "./tsconfig.json"
   }
 }
diff --git a/examples/solid/simple/.eslintrc b/examples/solid/simple/.eslintrc
@@ -1,11 +1,6 @@
 {
   "extends": ["plugin:@tanstack/eslint-plugin-query/recommended"],
   "parserOptions": {
-    "project": "./tsconfig.json",
-    "sourceType": "module"
-  },
-  "rules": {
-    "react/react-in-jsx-scope": "off",
-    "jsx-a11y/accessible-emoji": "off",
+    "project": "./tsconfig.json"
   }
 }
diff --git a/examples/solid/solid-start-streaming/.eslintrc b/examples/solid/solid-start-streaming/.eslintrc
@@ -1,7 +1,5 @@
 {
-  "extends": ["../../../.eslintrc"],
-  "rules": {
-    "react/react-in-jsx-scope": "off",
-    "import/no-unresolved": "off"
+  "parserOptions": {
+    "project": "./tsconfig.json"
   }
 }
diff --git a/nx.json b/nx.json
@@ -31,7 +31,7 @@
       "{workspaceRoot}/tsconfig.base.json",
       "{workspaceRoot}/package.json"
     ],
-    "globalNonBuildAffectingConfig": ["{workspaceRoot}/.eslintrc"],
+    "globalNonBuildAffectingConfig": ["{workspaceRoot}/.eslintrc.cjs"],
     "default": [
       "{projectRoot}/**/*",
       "globalBuildAffectingConfig",
@@ -41,9 +41,9 @@
     ],
     "public": [
       "default",
-      "!{workspaceRoot}/.eslintrc",
+      "!{workspaceRoot}/.eslintrc.cjs",
       "!{projectRoot}/**/?(*.)+(spec|test).[jt]s?(x)?(.snap)",
-      "!{projectRoot}/.eslintrc*",
+      "!{projectRoot}/.eslintrc.cjs",
       "!{projectRoot}/tsconfig.eslint.json"
     ]
   },

diff --git a/package.json b/package.json
@@ -65,12 +65,8 @@
     "current-git-branch": "^1.1.0",
     "eslint": "^8.34.0",
     "eslint-config-prettier": "^8.8.0",
-    "eslint-config-react-app": "^7.0.1",
     "eslint-import-resolver-typescript": "^3.5.5",
     "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-jsx-a11y": "^6.7.1",
-    "eslint-plugin-prettier": "^4.2.1",
-    "eslint-plugin-promise": "^6.1.1",
     "eslint-plugin-react": "^7.32.2",
     "eslint-plugin-react-hooks": "^4.6.0",
     "git-log-parser": "^1.2.0",

diff --git a/packages/codemods/.eslintrc.cjs b/packages/codemods/.eslintrc.cjs
@@ -2,8 +2,6 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs'],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',

diff --git a/packages/eslint-plugin-query/.eslintrc.cjs b/packages/eslint-plugin-query/.eslintrc.cjs
@@ -2,8 +2,6 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs'],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',

diff --git a/packages/query-async-storage-persister/.eslintrc.cjs b/packages/query-async-storage-persister/.eslintrc.cjs
@@ -2,8 +2,6 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs'],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',

diff --git a/packages/query-broadcast-client-experimental/.eslintrc.cjs b/packages/query-broadcast-client-experimental/.eslintrc.cjs
@@ -2,8 +2,6 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs'],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',

diff --git a/packages/query-core/.eslintrc.cjs b/packages/query-core/.eslintrc.cjs
@@ -2,8 +2,6 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs'],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',

diff --git a/packages/query-devtools/.eslintrc.cjs b/packages/query-devtools/.eslintrc.cjs
@@ -2,8 +2,6 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs'],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',

diff --git a/packages/query-persist-client-core/.eslintrc.cjs b/packages/query-persist-client-core/.eslintrc.cjs
@@ -2,8 +2,6 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs'],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',

diff --git a/packages/query-sync-storage-persister/.eslintrc.cjs b/packages/query-sync-storage-persister/.eslintrc.cjs
@@ -2,8 +2,6 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs'],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',

diff --git a/packages/react-query-devtools/.eslintrc.cjs b/packages/react-query-devtools/.eslintrc.cjs
@@ -2,8 +2,10 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs', 'react-app',],
+  extends: [
+    'plugin:react/recommended',
+    'plugin:react-hooks/recommended',
+  ],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',

diff --git a/packages/react-query-persist-client/.eslintrc.cjs b/packages/react-query-persist-client/.eslintrc.cjs
@@ -2,8 +2,10 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs', 'react-app',],
+  extends: [
+    'plugin:react/recommended',
+    'plugin:react-hooks/recommended',
+  ],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',

diff --git a/packages/react-query/.eslintrc.cjs b/packages/react-query/.eslintrc.cjs
@@ -2,8 +2,10 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs', 'react-app',],
+  extends: [
+    'plugin:react/recommended',
+    'plugin:react-hooks/recommended',
+  ],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',

diff --git a/packages/solid-query/.eslintrc.cjs b/packages/solid-query/.eslintrc.cjs
@@ -2,8 +2,6 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs'],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',

diff --git a/packages/svelte-query-devtools/.eslintrc.cjs b/packages/svelte-query-devtools/.eslintrc.cjs
@@ -2,8 +2,7 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs', 'plugin:svelte/recommended'],
+  extends: ['plugin:svelte/recommended'],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.json',

diff --git a/packages/svelte-query/.eslintrc.cjs b/packages/svelte-query/.eslintrc.cjs
@@ -2,8 +2,7 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs', 'plugin:svelte/recommended'],
+  extends: ['plugin:svelte/recommended'],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.json',

diff --git a/packages/vue-query/.eslintrc.cjs b/packages/vue-query/.eslintrc.cjs
@@ -2,8 +2,6 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  root: true,
-  extends: ['../../.eslintrc.cjs'],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './tsconfig.eslint.json',