Replies: 1 comment 2 replies
-
yeah I think we can do that. we use pnpm workspaces, so I think the dependency must go from would you like to PR it? I think this would apply to all packages that have peerDependencies depending on another package in the same workspace. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello! The
peerDependency
from@tanstack/react-query-devtools
is pinned to a version of react-query. We ship a small library for our teams to use that includes the devtools as a dependency, but lists react-query as apeerDependency
so that teams can upgrade the version without needing our involvement.This leads to failing peerDependencies though. If a team tries to update
@tanstack/react-query
, it fails the pinned version from@tanstack/react-query-devtools
. Since that library is brought in transitively, it's not even listed in their dependencies, so you have to update the resolutions which is an extra step that some teams are unfamiliar with doing (we use Yarn v3 if that helps your understanding of how to manually update resolutions.We can try to solve this on our end in a few ways (listing the devtools as a peerDep so it's directly installed), but I was wondering if you would be open to changing the range to a carat one which would get around the problem entirely?
Beta Was this translation helpful? Give feedback.
All reactions