Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ssr): Hydration caveat for Next.js rewrites #3209

Merged
merged 1 commit into from
Jan 21, 2022
Merged

docs(ssr): Hydration caveat for Next.js rewrites #3209

merged 1 commit into from
Jan 21, 2022

Conversation

bennettdams
Copy link
Contributor

@bennettdams bennettdams commented Jan 18, 2022

This adds a small section for a caveat about hydration when using some specific feature/configuration of Next.js.

See initial RQ discussion: #3192

See Next.js issue: vercel/next.js#33028 (comment)


I'm not sure if we should additionally reference the Next.js issue for this topic in the RQ docs, but my hopes are not high that the issue will be fixed "this time", as it is not really a bug per se, so I didn't here.

Adds a small section for a caveat about hydration when using some specific feature/configuration of Next.js
@vercel
Copy link

vercel bot commented Jan 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/EQfstdRzbiwc4nawiL6P1tbC8qHd
✅ Preview: https://react-query-git-fork-bennettdams-patch-4-tanstack.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c12f2de:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #3209 (c12f2de) into master (e328ca0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3209   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files          45       45           
  Lines        2270     2270           
  Branches      639      639           
=======================================
  Hits         2190     2190           
  Misses         77       77           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e328ca0...c12f2de. Read the comment docs.

@bennettdams
Copy link
Contributor Author

Maybe @Ephem has some more insights on this topic, so we could give guidance on how to tackle this in the docs?

@TkDodo TkDodo merged commit f5a0cec into TanStack:master Jan 21, 2022
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.34.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-alpha.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants