Yet another test stability improvements PR #4397
Conversation
zorzysty
force-pushed
the
yet_another_test_stabilization_improvements
branch
from
08f1b3a
to
52da440
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 08f1b3a:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 964147c:
|
Codecov ReportBase: 96.36% // Head: 92.27% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4397 +/- ##
==========================================
- Coverage 96.36% 92.27% -4.09%
==========================================
Files 45 87 +42
Lines 2281 3561 +1280
Branches 640 902 +262
==========================================
+ Hits 2198 3286 +1088
- Misses 80 259 +179
- Partials 3 16 +13 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| }) | ||
|
|
||
| fireEvent.click(rendered.getByRole('button', { name: 'remove' })) | ||
|
|
There was a problem hiding this comment.
I think here we need a longer sleep (100) after the button click. As the title suggests:
'should not get into an infinite loop when removing a query with cacheTime 0 and rerendering'
How do we detect an infinite loop? We wait a bit and wait what the states length is. If it's still 5 after 100ms, it's not an infinite loop. If it were, it would be anywhere between 30 and 50 or so :)
…r data is successfully fetched for the second time
…mprovements' into yet_another_test_stabilization_improvements
…mprovements' into yet_another_test_stabilization_improvements
…eviousData is set"
zorzysty
changed the title
No description provided.