Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unwrap queryKey in queryFn for overloads #4410

Merged
merged 1 commit into from Oct 30, 2022

Conversation

DamianOsipiuk
Copy link
Contributor

Closes: #4387

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02272e6:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

Base: 96.36% // Head: 92.27% // Decreases project coverage by -4.08% ⚠️

Coverage data is based on head (02272e6) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4410      +/-   ##
==========================================
- Coverage   96.36%   92.27%   -4.09%     
==========================================
  Files          45       87      +42     
  Lines        2281     3561    +1280     
  Branches      640      902     +262     
==========================================
+ Hits         2198     3286    +1088     
- Misses         80      259     +179     
- Partials        3       16      +13     
Impacted Files Coverage Δ
src/react/logger.native.ts
src/devtools/useMediaQuery.ts
src/react/useQueries.ts
src/core/hydration.ts
src/core/queryClient.ts
src/devtools/Logo.tsx
src/core/mutationObserver.ts
src/devtools/utils.ts
src/core/logger.ts
src/react/Hydrate.tsx
... and 122 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DamianOsipiuk DamianOsipiuk merged commit fe67cb7 into TanStack:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue refs aren't unwrapped in query key type in query context
2 participants