Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run exhaustive dep check on referenced query key #4480

Merged

Conversation

Newbie012
Copy link
Collaborator

@Newbie012 Newbie012 commented Nov 7, 2022

fixes #4475

image

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 571b609:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@Newbie012 Newbie012 force-pushed the fix-eslint-plugin-referenced-query-key branch from b15cc8b to f14f185 Compare November 7, 2022 23:02
@Newbie012
Copy link
Collaborator Author

@TkDodo Something odd just happened. The Lint job has failed on eslint errors that occurred before I made this PR. I fixed them in f14f185.

@TkDodo
Copy link
Collaborator

TkDodo commented Nov 11, 2022

I merged the other PR first so now they are conflicts here

@Newbie012
Copy link
Collaborator Author

There seems to be another flaky test.

About the issue I wrote above, it seems like I was wrong. I had 1 problem from this PR and a few warnings which won't fail in CI. What's the reasoning for not marking all rules as problems when running as CI?

@codecov-commenter
Copy link

Codecov Report

Base: 96.36% // Head: 92.40% // Decreases project coverage by -3.95% ⚠️

Coverage data is based on head (571b609) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4480      +/-   ##
==========================================
- Coverage   96.36%   92.40%   -3.96%     
==========================================
  Files          45       88      +43     
  Lines        2281     3648    +1367     
  Branches      640      956     +316     
==========================================
+ Hits         2198     3371    +1173     
- Misses         80      261     +181     
- Partials        3       16      +13     
Impacted Files Coverage Δ
src/react/reactBatchedUpdates.ts
src/devtools/Explorer.tsx
src/react/useIsMutating.ts
src/devtools/tests/utils.tsx
src/react/utils.ts
src/react/setBatchUpdatesFn.ts
...rc/createWebStoragePersistor-experimental/index.ts
src/core/retryer.ts
src/core/focusManager.ts
src/core/queriesObserver.ts
... and 123 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo
Copy link
Collaborator

TkDodo commented Nov 11, 2022

About the issue I wrote above, it seems like I was wrong. I had 1 problem from this PR and a few warnings which won't fail in CI. What's the reasoning for not marking all rules as problems when running as CI?

eslint rules should be either errors or warnings, independent of environment. We can make some rules from warning to error if they are important to be fixed.

@TkDodo TkDodo merged commit 82adc95 into TanStack:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-plugin-query: exhaustive deps not reported when queryKey is an external const
3 participants