-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run exhaustive dep check on referenced query key #4480
run exhaustive dep check on referenced query key #4480
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 571b609:
|
b15cc8b
to
f14f185
Compare
I merged the other PR first so now they are conflicts here |
There seems to be another flaky test. About the issue I wrote above, it seems like I was wrong. I had 1 problem from this PR and a few warnings which won't fail in CI. What's the reasoning for not marking all rules as problems when running as CI? |
Codecov ReportBase: 96.36% // Head: 92.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4480 +/- ##
==========================================
- Coverage 96.36% 92.40% -3.96%
==========================================
Files 45 88 +43
Lines 2281 3648 +1367
Branches 640 956 +316
==========================================
+ Hits 2198 3371 +1173
- Misses 80 261 +181
- Partials 3 16 +13 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
eslint rules should be either errors or warnings, independent of environment. We can make some rules from warning to error if they are important to be fixed. |
fixes #4475