Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-persist-client-core): Move query-core to dependencies #4899

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

adriencohen
Copy link
Contributor

@adriencohen adriencohen commented Jan 30, 2023

Moves query-core to dependencies of query-persist-client-core so packages using query-persist-client-core don't have an unmet peer dependency warning

Closes #4885

@vercel
Copy link

vercel bot commented Jan 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
query ⬜️ Ignored (Inspect) Jan 30, 2023 at 8:51AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 482ea17:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

Base: 91.69% // Head: 91.69% // No change to project coverage 👍

Coverage data is based on head (482ea17) compared to base (7a62494).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4899   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files         111      111           
  Lines        4129     4129           
  Branches     1062     1062           
=======================================
  Hits         3786     3786           
  Misses        322      322           
  Partials       21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo TkDodo merged commit 64dc3af into TanStack:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmet peer dependencies error with @tanstack/query-persist-client-core
3 participants