Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svelte-query): use store for reactivity in options #5050

Merged
merged 6 commits into from
Mar 3, 2023

Conversation

chrislcs
Copy link

New version of the accidentally closed PR: #4995


To fix #4851

This adds the option to use a writable store for the query options, so that svelte query can react appropriately when these options change. The current method of reactivity recreates the entire query each time an option is changed, which causes issues.

@vercel
Copy link

vercel bot commented Feb 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
query ⬜️ Ignored (Inspect) Mar 3, 2023 at 9:55PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eef9534:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration
ecstatic-mayer-7jm2ll Issue #4851

Copy link
Member

@lachlancollins lachlancollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please fix the merge conflict then it'll be right to go!

@chrislcs
Copy link
Author

chrislcs commented Mar 1, 2023

Conflicts should be solved

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Patch coverage: 94.64% and project coverage change: -0.08 ⚠️

Comparison is base (ca2f697) 90.50% compared to head (eef9534) 90.42%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #5050      +/-   ##
==========================================
- Coverage   90.50%   90.42%   -0.08%     
==========================================
  Files         104      105       +1     
  Lines        3811     3791      -20     
  Branches      961      952       -9     
==========================================
- Hits         3449     3428      -21     
- Misses        329      330       +1     
  Partials       33       33              
Impacted Files Coverage Δ
packages/query-core/src/query.ts 99.02% <ø> (ø)
packages/react-query/src/useInfiniteQuery.ts 100.00% <ø> (ø)
packages/solid-query/src/createInfiniteQuery.ts 100.00% <ø> (ø)
packages/svelte-query/src/createInfiniteQuery.ts 0.00% <ø> (ø)
packages/svelte-query/src/createQuery.ts 100.00% <ø> (ø)
packages/vue-query/src/queryClient.ts 93.22% <ø> (ø)
packages/vue-query/src/useBaseQuery.ts 100.00% <ø> (ø)
packages/vue-query/src/useInfiniteQuery.ts 100.00% <ø> (ø)
packages/vue-query/src/useQuery.ts 100.00% <ø> (ø)
packages/svelte-query/src/createBaseQuery.ts 83.33% <81.25%> (+1.51%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants