fix some false positive for prefer-query-object-syntax rule

[eg-bernardo]

Fixes #5028, and cases where the query options object is not defined in the same file as the useQuery call.

To be able to test the issue with satisfies I had to update typescript and @typescript-eslint packages, but I have only updated devDependencies in eslint-plugin-query.

I have removed a test case for invalid code:

import { useQuery } from "@tanstack/react-query";
useQuery(queryKey);

Because I think in most cases for useQuery(some_variable) when some_variable is not defined in the current file, it will be a query options object.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
query	⬜️ Ignored (Inspect)	Visit Preview		Sep 6, 2023 6:10am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 653917f:

Sandbox	Source
@tanstack/query-example-react-basic-typescript	Configuration
@tanstack/query-example-solid-basic-typescript	Configuration
@tanstack/query-example-svelte-basic	Configuration
@tanstack/query-example-vue-basic	Configuration

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 653917f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

🟥 Failed Commands
nx affected --targets=test:eslint,test:lib,test:types,test:build

✅ Successfully ran 1 target

• nx affected --targets=test:lib --base=ef5125f68bc41c6c01219f7cb4b098b8d35a2045

---

Sent with 💌 from NxCloud.

[TkDodo]

where are we using an older version of @typescript-eslint/parser ?

[eg-bernardo]

here:

query/package.json

Line 61 in ef5125f

"@typescript-eslint/parser": "^5.41.0",

I came to the conclusion that I also needed to update typescript to >=4.9 to be able to test satisfies and I didn't wan't to change the typescript version in the respository root. But maybe I can update @typescript-eslint in the root. I will give it another look.

[eg-bernardo]

I have tried updating only @typescript-eslint/* packages to oldest version that suports satisfies (5.45.0), but that is not enough, typescript >=4.9 is also needed, otherwise the test that uses satisfies fails with A fatal parsing error occurred: Parsing error: ',' expected.

I didn't want to update the typescript version in the root, because I assumed that it is probably there to ensure that packages stay compatible with that version of typescript.

[TkDodo]

ah yes, I see. what we'd want is to develop with TS 5.2, but have a type-testing suite that works against all sorts of TS versions.

@ZackDeRose started with this some time back, but we never followed through:

• Bunch of repo admin stuff from Nx Live Stream #5640

I'll take a look at setting this up later this week, then we should be good without this workaround 👍

[Newbie012]

My personal take:
I think it would be wrong to remove the 2 tests, since useQuery(["query-key"]) is considered a valid syntax in older versions.
Last thing, consider adding another 2 separate tests - one with only as const and one with only satisfies.

Other than that, LGTM.

[eg-bernardo]

I think githubs diff is not being very helpful, because I have only removed one test and added two here: 27b7153 and then added another here 331fa08. It's clearer in the diffs for the individual commits.

The test for useQuery(["queryKey"]) is still there

query/packages/eslint-plugin-query/src/rules/prefer-query-object-syntax/prefer-query-object-syntax.test.ts

Line 177 in 331fa08

useQuery(['data']);

[TkDodo]

@eg-bernardo can you please fix the conflicts than we can go ahead and merge this fix

[eg-bernardo]

This PR is only relevant for v4 since prefer-query-object-syntax is no longer required on v5.

Also it was blocked because it required typescript 4.9:
#5953 (comment)

and you said:
#5953 (comment)

But it seems v4 still targets typescript 4.7.

[TkDodo]

you're right, I'll close this then.