Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query-core): remove queryKey check in production environment #5969

Merged

Conversation

Mini-ghost
Copy link
Contributor

@Mini-ghost Mini-ghost commented Sep 6, 2023

Before

This is production code(to see clearly, I turned off minify), and if (!Array.isArray(this.options.queryKey)) is in there

截圖 2023-09-07 上午7 00 08

After

if (!Array.isArray(this.options.queryKey)) be removed in production.

截圖 2023-09-07 上午7 05 03

@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2023 4:14pm

@nx-cloud
Copy link

nx-cloud bot commented Sep 6, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7537024. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7537024:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@DamianOsipiuk DamianOsipiuk changed the title refactor(query-core): remove queryKey check in development environment refactor(query-core): remove queryKey check in production environment Sep 7, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage is 100.00% of modified lines.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Changed Coverage
packages/query-core/src/query.ts 100.00%

📢 Thoughts on this report? Let us know!.

@DamianOsipiuk DamianOsipiuk merged commit 423bcf0 into TanStack:main Sep 7, 2023
10 checks passed
@Mini-ghost Mini-ghost deleted the refactor/improve-production-code branch September 9, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants