-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(vue-query): reuse parsing utility functions from query-core
#5984
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9ab7618. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9ab7618:
|
Codecov ReportPatch coverage is ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
query-core
query-core
All those utils have been removed in v5 because they are no longer necessary. |
I can't wait to upgrade to v5! Also, will this PR make it difficult to merge the |
yeah potentially, not sure. @DamianOsipiuk knows :) 5.0-rc is coming soon! |
I would prefer to leave it as-is, since gains are not huge. |
In query-core, there are several utility functions provided, such as
parseQueryArgs
,parseMutationArgs
,parseFilterArgs
, andparseMutationFilterArgs
. These can be reused in vue-query, and all we need to do is unwrapref
and perform deep cloning to track nested reactive data.This PR can reduce the bundle size a little bit