Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove suspense form defaultOptions #6301

Merged
merged 3 commits into from
Nov 5, 2023

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Nov 3, 2023

we don't want to be able to set suspense: true globally like this anymore: React has useSuspenseQuery and other frameworks don't need it either

fixes #6300

we don't want to be able to set `suspense: true` globally like this anymore: React has `useSuspenseQuery` and other frameworks don't need it either
Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2023 3:01pm

Copy link

nx-cloud bot commented Nov 3, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ce1d328. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Nov 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ce1d328:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

see 12 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@TkDodo TkDodo merged commit 6ee0671 into main Nov 5, 2023
9 checks passed
@TkDodo TkDodo deleted the feature/6300-suspense-defaultOptions branch November 5, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suspense still available in defaultOptions
2 participants