New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: qwik-query package #6436
feat: qwik-query package #6436
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b9cda09:
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3e75b2e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work 👏
some options typings are set to any
, so I guess we need to figure this out before publishing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use vitest
for all our other packages as test manager. Would it be possible to stick with that for qwik, too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately with Vitest I have some problem with Qwik, Cypress works like a charm, but I understand your point of view.
export { useMutation } from './useMutation' | ||
export { useIsMutating } from './useIsMutating' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v5 has a new useMutationState
hook that you might want to implement in qwik as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the queryOptions
aren't exported from the src/index.ts
file ?
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
oh, you might also want to add an integration test: https://github.com/TanStack/query/tree/83d71c307410933909dce1c7e5579c6e36747195/integrations basically a minimal example where we run the |
Yep, in fact I really would like an help to figure out the right types |
can you please update with main and fix the conflicts - we've release the angular adapter today 🎉 let me see if I can help with the types |
I'm trying to help with that, but there's still a lot of work to be done: gioboa#1 |
@gradddev is doing a great job on the right direction. I'm looking forward to seeing the integration finalised. |
Dude, I can't wait for this to release! I've been doing a weekly checkin since the last (now closed) PR. 🤣 |
@@ -7,4 +7,4 @@ packages: | |||
- 'examples/svelte/*' | |||
- 'examples/vue/*' | |||
- '!examples/vue/2*' | |||
- '!examples/vue/nuxt*' | |||
- '!examples/vue/nuxt*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- '!examples/vue/nuxt*' | |
- '!examples/vue/nuxt*' | |
I don't have the energy to finalise this PR now. I'm thinking at this integration twice a week but it's not correct to keep a stale PR in the repository. So I close this PR for now, I'm more than happy to explain the current situation of the PR to new contributions. I'm so sorry. Cheers 😔 |
This pull request adds Qwik adapter for TanStack Query.
I covered:
useQuery
useInfiniteQuery
userQueries
useIsFetching
useMutation
useIsMutating
It's draft because I need to cover these things
To avoid a huge PR with too many lines of code these tasks will be in future PRs