Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin-query): Update @typescript-eslint/utils to v6 #6819

Merged
merged 8 commits into from
Feb 10, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Feb 3, 2024

Changes documented here: https://typescript-eslint.io/blog/announcing-typescript-eslint-v6#developer-facing-changes

Passes all tests, and errors show up in examples when you introduce incorrect code (e.g. removing a key from useInfiniteQuery in useAlgolia.ts generates an exhaustive-deps error).

This also unblocks switching to @typescript-eslint/parser v6 and @typescript-eslint/eslint-plugin v6

With project: true, eslint errors now show up correctly in examples (reads closest tsconfig.json)

Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2024 6:23am

Copy link

nx-cloud bot commented Feb 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c8ab7a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bfdd31f) 41.76% compared to head (2711d96) 41.78%.

Files Patch % Lines
...ackages/eslint-plugin-query/src/utils/ast-utils.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6819      +/-   ##
==========================================
+ Coverage   41.76%   41.78%   +0.01%     
==========================================
  Files         178      178              
  Lines        7017     7014       -3     
  Branches     1421     1418       -3     
==========================================
  Hits         2931     2931              
+ Misses       3723     3720       -3     
  Partials      363      363              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins changed the title feat(eslint-plugin-query): Update to @typescript-eslint/utils v6 feat(eslint-plugin-query): Update @typescript-eslint/utils to v6 Feb 3, 2024
Copy link

codesandbox-ci bot commented Feb 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6457bac:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@lachlancollins lachlancollins merged commit bd01186 into main Feb 10, 2024
3 checks passed
@lachlancollins lachlancollins deleted the update-ts-eslint branch February 10, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants