Feature/7055 stale disabled queries #7059
Conversation
…ptions weren't defaulted non-defaulted prev options indicate a "mount" event, in which case we don't want to fire an "update" event
with the new assumption that disabled observers are not stale
with the new assumption that disabled observers are not stale
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
package: react-query
package: query-core
package: solid-query
labels
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 68082b6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 68082b6:
|
accidentally removed to test a failing test
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #7059 +/- ##
==========================================
+ Coverage 41.47% 41.51% +0.04%
==========================================
Files 184 184
Lines 7304 7309 +5
Branches 1509 1511 +2
==========================================
+ Hits 3029 3034 +5
Misses 3876 3876
Partials 399 399 |
that check looks for data not undefined anyways, but it also returns "fresh" for disabled observers now
don't count disabled observers as
isStale: truedisabled observers will never trigger a smart refetch on events (window focus etc) because they are disabled - they can't trigger fetches on their own. So they shouldn't show up as
isStalejust because their staleTime elapsed.closes #7055