Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vue-query): add vite.config.ts as tsconfig's include field #7063

Merged
merged 5 commits into from Mar 11, 2024

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Mar 9, 2024

simply resolve this error

image

Copy link

vercel bot commented Mar 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2024 1:33am

Copy link

nx-cloud bot commented Mar 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fbdce62. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@manudeli manudeli marked this pull request as ready for review March 9, 2024 17:37
@manudeli manudeli changed the title chore(vue-query): ad vite.config.ts as tsconfig include chore(vue-query): add vite.config.ts as tsconfig include Mar 9, 2024
@manudeli manudeli changed the title chore(vue-query): add vite.config.ts as tsconfig include chore(vue-query): add vite.config.ts as tsconfig's include field Mar 9, 2024
Copy link

codesandbox-ci bot commented Mar 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fbdce62:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@manudeli manudeli marked this pull request as draft March 9, 2024 17:52
@@ -16,6 +16,7 @@ export default defineConfig({
if (log.includes('Download the Vue Devtools extension')) {
return false
}
return undefined
Copy link
Contributor Author

@manudeli manudeli Mar 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add return undefined to resolve this error

image

@manudeli manudeli marked this pull request as ready for review March 9, 2024 19:08
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2024

Codecov Report

Merging #7063 (fbdce62) into main (181e9d2) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7063   +/-   ##
=======================================
  Coverage   41.69%   41.69%           
=======================================
  Files         184      184           
  Lines        7262     7262           
  Branches     1471     1471           
=======================================
  Hits         3028     3028           
  Misses       3848     3848           
  Partials      386      386           
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.46% <ø> (ø)
@tanstack/eslint-plugin-query 85.11% <ø> (ø)
@tanstack/query-async-storage-persister 49.20% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 93.23% <ø> (ø)
@tanstack/query-devtools 4.09% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 92.77% <ø> (ø)
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 82.26% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 62.68% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.81% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit 4254b62 into TanStack:main Mar 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants