feat: pass context to mutationFn

[momme-rtf]

Since the onMutate function offers a place for preprocessing I'd find it helpful if not only the onError, onSuccess , ... callbacks receive the context (returned by the onMutate) as an input parameter but also the mutationFn.

Discussion

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
query	⬜️ Ignored (Inspect)	Visit Preview		Mar 13, 2024 7:31am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 14c4b98:

Sandbox	Source
@tanstack/query-example-angular-basic	Configuration
@tanstack/query-example-react-basic-typescript	Configuration
@tanstack/query-example-solid-basic-typescript	Configuration
@tanstack/query-example-svelte-basic	Configuration
@tanstack/query-example-vue-basic	Configuration

[TkDodo]

if we think this through, when we should build something similar to the QueryFunctionContext - an object that we pass as second parameter. The return value from onMutate would just be one thing that goes there, meta could be another (same as useQuery) and someday maybe even an AbortSignal.

Naming will be weird - I would like this object to be the MutationFunctionContext, but then we'd need another word than "context" for what the onMutate function returns 🤔

[momme-rtf]

Hmm interesting.. What if the return value of onMutate would just contribute to the meta prop instead of being a separate property in the MutationFunctionContext?

[TkDodo]

not sure if that would be betterl. To be on par with queries, meta should be what the user defines meta to be

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 14c4b98. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3

---

Sent with 💌 from NxCloud.