Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(*): add husky + lint-staged + prettier to remove chance to meet test:format error #7123

Merged
merged 2 commits into from Mar 16, 2024

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Mar 16, 2024

When I make Pull Request, Pretty frequently I encounter test:format error in ci.

So I think we should remove chance to meet this error by like below automatically by using husky + lint-staged + prettier

Mar-16-2024 14-58-51

Copy link

vercel bot commented Mar 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2024 7:31pm

@manudeli manudeli changed the title ci(*): add husky + lint-staged + prettier to reduce chance to meet te… ci(*): add husky + lint-staged + prettier to reduce chance to meet test:format error Mar 16, 2024
Copy link

nx-cloud bot commented Mar 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 48a1c82. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Mar 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 48a1c82:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@manudeli manudeli force-pushed the ci/husky+lint-staged+prettier branch 3 times, most recently from 758b3be to bbf0ad6 Compare March 16, 2024 06:29
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

Merging #7123 (c2eb992) into main (93674fe) will increase coverage by 0.05%.
Report is 11 commits behind head on main.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7123      +/-   ##
==========================================
+ Coverage   41.42%   41.48%   +0.05%     
==========================================
  Files         184      184              
  Lines        7331     7331              
  Branches     1531     1521      -10     
==========================================
+ Hits         3037     3041       +4     
- Misses       3889     3895       +6     
+ Partials      405      395      -10     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.46% <ø> (ø)
@tanstack/eslint-plugin-query 85.29% <ø> (ø)
@tanstack/query-async-storage-persister 49.20% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 93.54% <93.10%> (+0.28%) ⬆️
@tanstack/query-devtools 3.93% <0.00%> (-0.01%) ⬇️
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 92.77% <ø> (ø)
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 82.54% <ø> (+0.27%) ⬆️
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 62.68% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.81% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@manudeli manudeli changed the title ci(*): add husky + lint-staged + prettier to reduce chance to meet test:format error ci(*): add husky + lint-staged + prettier to remove chance to meet test:format error Mar 16, 2024
@manudeli manudeli force-pushed the ci/husky+lint-staged+prettier branch from ce616bb to cb0b2f9 Compare March 16, 2024 14:52
@manudeli manudeli force-pushed the ci/husky+lint-staged+prettier branch from cb0b2f9 to c2eb992 Compare March 16, 2024 14:57
@manudeli manudeli marked this pull request as ready for review March 16, 2024 15:02
Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. I've seen this in PRs lately and it drives me crazy. Why do people not run prettier in their editors locally on save. Beats me 🤷‍♂️

@TkDodo TkDodo merged commit a6da187 into TanStack:main Mar 16, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants