Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.vscode): codeActionsOnSave #7157

Closed
wants to merge 1 commit into from

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Mar 22, 2024

If new contributors edit the markdown file with no pnpm prepare, husky will not work, so prettier will not work for pre-commit.

I'd like to automate these cases so this case don't keep making prettier errors. Since VSCode is the tool most used by front-end developers, I thought it would be a good idea to set prettier to run on save.

Motivating things

Hope we could concentrate more important things with automation

Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 8:41am

Copy link

nx-cloud bot commented Mar 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8b8cbd0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b8cbd0:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration

@codecov-commenter
Copy link

Codecov Report

Merging #7157 (8b8cbd0) into main (93674fe) will decrease coverage by 0.10%.
Report is 26 commits behind head on main.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7157      +/-   ##
==========================================
- Coverage   41.42%   41.32%   -0.10%     
==========================================
  Files         184      183       -1     
  Lines        7331     7322       -9     
  Branches     1531     1524       -7     
==========================================
- Hits         3037     3026      -11     
- Misses       3889     3892       +3     
+ Partials      405      404       -1     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.46% <ø> (ø)
@tanstack/eslint-plugin-query 85.29% <ø> (ø)
@tanstack/query-async-storage-persister 49.20% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 93.44% <93.10%> (+0.18%) ⬆️
@tanstack/query-devtools 3.93% <0.00%> (-0.01%) ⬇️
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 92.77% <ø> (ø)
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 81.27% <25.00%> (-1.00%) ⬇️
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 62.68% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.98% <81.81%> (+0.16%) ⬆️
@tanstack/vue-query-devtools ∅ <ø> (∅)

@manudeli manudeli marked this pull request as ready for review March 22, 2024 08:48
@TkDodo
Copy link
Collaborator

TkDodo commented Mar 22, 2024

I don't think we should check in editor specific settings. Often, we change markdown files directly in GitHub. I personally don't use vscode. So I think this is just something we have to live with

@TkDodo TkDodo closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants