Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rows don't render in IE11 #564

Closed
mikedevita opened this issue Oct 20, 2017 · 12 comments
Closed

Rows don't render in IE11 #564

mikedevita opened this issue Oct 20, 2017 · 12 comments
Labels
critical Issues or bugs that are highly critical and must be solved as soon as possible.

Comments

@mikedevita
Copy link
Contributor

mikedevita commented Oct 20, 2017

What version of React-Table are you using?

6.5.3

What bug are you experiencing, or what feature are you proposing?

Rows are not visible, but they exist in DOM

Use https://codesandbox.io/s/X6npLXPRW (by clicking the "Fork" button) to reproduce the issue.

https://codesandbox.io/embed/gLwmmjzA3?autoresize=1&hidenavigation=1&view=split

What are the steps to reproduce the issue?

  1. load sandbox in IE11
  2. table rows are not visible

image
image

@gary-menzel
Copy link
Contributor

I have done a check on this (although I don't use IE very much). It appears that using flex: auto 1 in the .ReactTable .rt-table css (instead of flex: 1) fixes this problem. However, while I tested it also in Chrome, I am not sure if it will be compatible with all browsers.

@mikedevita
Copy link
Contributor Author

thanks Gary I'll test this on my app on Monday to see if it's a viable work around.

@mikedevita
Copy link
Contributor Author

@gary-menzel I can confirm that adding the following css resolves the issue, is this going to be planned to push into the next release?

.ReactTable .rt-table {
  flex: auto 1;
}

@gary-menzel
Copy link
Contributor

Really up to @tannerlinsley. It would still need to be tested across all the currently supported browsers. But, as overriding CSS is fairly simple, it is likely to have low priority. I will definitely add an FAQ to the github Wiki.

Thanks for the confirmation.

@mikedevita
Copy link
Contributor Author

yeah thats totally fine, i am in no rush to get a fix pushed so its up to @tannerlinsley entirely I'd say. Plus with a viable workaround there really no rush at all for any of my other projects.

@gary-menzel gary-menzel added critical Issues or bugs that are highly critical and must be solved as soon as possible. Priority:Low labels Oct 24, 2017
@jepz
Copy link

jepz commented Oct 24, 2017

Does the problem that IE 11 doesn't support property or method of find have anything to do with it?

@maxdarque
Copy link

Is this low priority? I understand there is an easy fix for this with the CSS override. Having said that, the product is fundamentally broken in a major use case...IE 11....

@mikedevita
Copy link
Contributor Author

there's already a PR for it. it's just waiting to be tested and merged. it's up to the core maintainers I think now.

@gary-menzel
Copy link
Contributor

Mike is correct.

For clarity, I have added a section to the FAQ that describes the triage levels.

https://github.com/react-tools/react-table/wiki/FAQ#what-is-the-criteria-for-assessing-issue-priority

@gary-menzel
Copy link
Contributor

#573

@maxdarque
Copy link

Thank you for taking the time to clarify this for me!

@gary-menzel
Copy link
Contributor

This should be addressed in V 6.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical Issues or bugs that are highly critical and must be solved as soon as possible.
Projects
None yet
Development

No branches or pull requests

4 participants