New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column header with blue outline after clicking for sorting #685
Comments
Thanks for that - checking in some changes against this issue now. Not sure how quickly it will make it into a release (but I have notified the owner). |
Yes noticed it too, the outline also wraps the column-resizer so it looks weird I think the outline is fine, just fixing the boundaries will be good (by moving resize handles out of focusable header buttons) |
The focus issue is a bug that has a PR in waiting to get released. |
I've recently started using React Table and noticed that this bug is still occurring. Using the Code Sandbox link referenced above (https://codesandbox.io/s/5knzrn8qmk) I updated the react-table dependency to 6.8.0 and the blue outline is still there. I've create a PR with a fix (see #881) |
Please see my comment on the PR. |
One thing that works for me is using the
The blue outline flickers so it isn't eliminated completely, but at least it doesn't hang around and be a distracting nuisance for people who do not need to track focus. Hope this helps others! |
Any news on that PR? I still have the Issue in 6.8.2 |
Add this to your CSS: .ReactTable .rt-thead [role="columnheader"] { |
I updated react-table which didn't work and I couldn't figure out how to add Mikkel-Vagn's css in without hardcoding it into the module files. This works for me though.
|
Following on from @cedricholz comment, incase this is of any use to anyone - I had grouped table headers, so used the getTheadGroupThProps function also:
|
|
What version of React-Table are you using?
Your bug may already be fixed in the latest release. Run
yarn upgrade react-table
!6.7.5
What bug are you experiencing, or what feature are you proposing?
As described in Title.
Refer to description by @gary-menzel in #682
Use https://codesandbox.io/s/X6npLXPRW (by clicking the "Fork" button) to reproduce the issue.
https://codesandbox.io/s/5knzrn8qmk
What are the steps to reproduce the issue?
The text was updated successfully, but these errors were encountered: