-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: test cross platform #1559
ci: test cross platform #1559
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 99fe42c:
|
I'm not sure why this is failing. Can anyone tell? |
@tannerlinsley Looks like |
As far as I can tell, I could revert the windows part and keep the MacOS and Linux part for now to unblock this, if folks prefer. |
👍
Tanner Linsley
…On Oct 4, 2019, 11:00 AM -0600, Christian Murphy ***@***.***>, wrote:
As far as I can tell, is-ci-cli has an issue where it is unable to detect travis ci for windows as a CI environment.
I've logged this upstream as watson/is-ci#19
I could revert the windows part and keep the MacOS and Linux part for now to unblock this, if folks prefer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I don't see how it wouldn't be detecting the TravisCI as a CI environment. I put out a PR on In the meantime, @ChristianMurphy you could try pointing to my fork and branch to see if it fixes it. |
@ChristianMurphy Can you try |
Test on Node.js 10 and 12, long term release support versions. Test on Linux, Mac, and Windows machines.
includes fixes to support windows
d10074b
to
6c1d631
Compare
Thanks @stramel, updated to |
Closing this in favor of #1578 |
@ChristianMurphy You can fix the issue by adding this to the env:
global:
- YARN_GPG=no |
@ChristianMurphy I wrote out a travis file for the |
@ChristianMurphy You might want to try removing the quotes around the script. I think that is causing windows to fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to note, that it's generally bad practice to have both package-lock.json
and yarn.lock
I agree. I'm not even sure how the package-lock.json got in there TBH |
Test on Node.js 10 and 12, long term release support versions.
Test on Linux, Mac, and Windows machines.