Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding caching for package deps in workflows #4767

Merged
merged 4 commits into from
Mar 25, 2023

Conversation

ZackDeRose
Copy link
Contributor

@ZackDeRose ZackDeRose commented Mar 20, 2023

What it does

  • adds caching of the node_modules between github action runs
  • changes to: yarn install --frozen-lockfile as the install step in ci (to match our yarn.lock file in source)

Benchmarks

Control run: https://github.com/TanStack/table/actions/runs/4458215445
New run w/ node_module caching: https://github.com/TanStack/table/actions/runs/4465120375

Control run New run w/ node_module caching
"Install Node.js" Step 0s 18s
"Install Dependencies" Step 1m 4s 23s
Total Time 3m 52s 2m 58s

@vercel
Copy link

vercel bot commented Mar 20, 2023

@ZackDeRose is attempting to deploy a commit to the Tanstack Team on Vercel.

A member of the Team first needs to authorize it.

@ZackDeRose ZackDeRose changed the title adding caching for node_modules in workflows WIP: adding caching for node_modules in workflows Mar 20, 2023
@ZackDeRose
Copy link
Contributor Author

adding a WIP for now until I get this right (need to do some test runs against github actions it looks like)

@ZackDeRose ZackDeRose changed the title WIP: adding caching for node_modules in workflows adding caching for package deps in workflows Mar 20, 2023
@ZackDeRose
Copy link
Contributor Author

Think this one is ready to go now - please let me know if there's an issue with using yarn --frozen-lockfile as our install command, but I think this should work well.

@KevinVandy KevinVandy merged commit d8c54a4 into TanStack:main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants