Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular-table): handle null and number values with flex-render #5550

Merged
merged 3 commits into from
May 13, 2024

Conversation

riccardoperra
Copy link
Contributor

@riccardoperra riccardoperra commented May 13, 2024

@KevinVandy grouping example was broken due to flexRenderDirective not handling null content (e.g. when a cell is grouped)

Screenshot 2024-05-13 alle 08 47 41

Here a screenshot of the grouping example after the fix

Copy link

nx-cloud bot commented May 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2b61063. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jrgokavalsa
Copy link
Contributor

@riccardoperra, I've observed an issue where the aggregatedCell function is not operating correctly in conjunction with age data. Upon debugging, I found that if aggregatedCell returns a number, no values are displayed. However, when it returns a string, it functions as expected. This behavior suggests that there might be a type-related discrepancy within the renderContent function's.

@riccardoperra
Copy link
Contributor Author

@jrgokavalsa Thanks I've forgot it. I've added a new check in order to support both string and numbers

@riccardoperra riccardoperra changed the title fix(angular-table): handle null values with flex-render fix(angular-table): handle null and number values with flex-render May 13, 2024
@KevinVandy KevinVandy merged commit f941ea6 into TanStack:main May 13, 2024
2 checks passed
@riccardoperra riccardoperra deleted the fix/angular-flex-render-null branch May 13, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants