Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular-query): WebContainers template for Stackblitz examples fixes broken Angular examples #183

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

arnoud-dv
Copy link
Contributor

By default, StackBlitz runs Angular CLI applications with an Angular template. WebContainers work much better however. StackBlitz are looking into changing this default In the meantime this commit adds the preset=node parameter to the StackBlitz embed which makes sure a WebContainers template is used (as described in the linked StackBlitz issue).

I confirmed all other framework examples already run as WebContainers even without the parameter so nothing will change there. Once the default template changes, the parameter can be removed.

The Angular examples based on the Angular CLI are currently non-functional in Stackblitz. See screenshots for the Angular infinite query example with and without preset=node

Screenshot 2024-02-10 at 22 27 28 Screenshot 2024-02-10 at 22 27 32

Copy link

vercel bot commented Feb 10, 2024

@arnoud-dv is attempting to deploy a commit to the Tanstack Team on Vercel.

A member of the Team first needs to authorize it.

@lachlancollins lachlancollins merged commit 9581f90 into TanStack:main Feb 10, 2024
2 of 3 checks passed
@arnoud-dv arnoud-dv deleted the fix/force-webcontainer branch February 10, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants