Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: place carbon ads on the right hand side and not left menu sidebar #91

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: place carbon ads on the right hand side and not left menu sidebar #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d36f2e9
fix: place carbon ads on the right hand side and not left menu sidebar
Jul 26, 2023
0eac246
feat: align to the right, and border radius to the left
Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/components/Docs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,9 +218,6 @@ export function Docs({
<div className="flex-1 flex flex-col gap-4 px-4 whitespace-nowrap overflow-y-auto text-base pb-[300px]">
{menuItems}
</div>
<div className="carbon-small absolute bottom-0 w-full">
<Carbon />
</div>
</div>
)

Expand Down Expand Up @@ -313,6 +310,9 @@ export function Docs({
</li>
</ul>
</div>
<div className="carbon-small p-6 fixed bottom-0">
<Carbon />
</div>
</aside>
</div>
)
Expand Down
4 changes: 0 additions & 4 deletions app/routes/blog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { Link, NavLink, Outlet } from '@remix-run/react'
import { MetaFunction } from '@remix-run/node'
import { DefaultErrorBoundary } from '~/components/DefaultErrorBoundary'
import { DefaultCatchBoundary } from '~/components/DefaultCatchBoundary'
import { Carbon } from '~/components/Carbon'
import { seo } from '~/utils/seo'

export const ErrorBoundary = DefaultErrorBoundary
Expand Down Expand Up @@ -118,9 +117,6 @@ export default function RouteBlog() {
<div className="flex-1 flex flex-col gap-4 px-4 whitespace-nowrap overflow-y-auto text-base">
{menuItems}
</div>
<div className="carbon-small absolute bottom-0 w-full">
<Carbon />
</div>
</div>
)

Expand Down
6 changes: 3 additions & 3 deletions app/styles/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,22 +118,22 @@
}

.carbon-small .carbon-wrap .carbon-img {
@apply w-[50%] pt-2 !pointer-events-auto rounded-tr-lg border-t border-r border-gray-500 border-opacity-10 overflow-hidden;
@apply w-[50%] pt-2 !pointer-events-auto rounded-tl-lg border-t border-r border-gray-500 border-opacity-10 overflow-hidden place-items-end;
}

.carbon-small .carbon-wrap .carbon-img img {
@apply w-full !max-w-full;
}

.carbon-small .carbon-wrap .carbon-text {
@apply bg-white dark:bg-gray-800 rounded-tr-lg !pb-6 !m-0 !pointer-events-auto border-t border-r border-gray-500 border-opacity-10;
@apply bg-white dark:bg-gray-800 rounded-tl-lg !pb-6 !m-0 !pointer-events-auto border-t border-r border-gray-500 border-opacity-10;
}

.carbon-small .carbon-wrap .carbon-poweredby {
@apply absolute bottom-0 right-0;
}

code[class*="language-"] {
code[class*='language-'] {
white-space: pre-wrap;
word-break: break-all;
}
2 changes: 1 addition & 1 deletion app/styles/carbon.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
}
#carbonads .carbon-img {
display: block;
margin: 0;
margin: 0 0 0 147px;
line-height: 1;
}
#carbonads .carbon-img img {
Expand Down