feat: Use ResizeObserver to listen to size changes #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach used a `requestAnimationFrame()` loop with calls to `getBoundingClientRect()` on every frame. Fixes TanStack#359
2 tasks
christiankaindl
force-pushed
the
resize-observer
branch
from
c536ba2
to
64e847b
Compare
|
Fantastic! Would you mind making this same change in react-charts? ;) |
|
The release is failing because of the dependency removal. It changed the output structure of the rollup files. npm run build locally and ensure the exports in package.json map to the correct output files. |
|
Thanks for merging so fast, awesome! 馃檶
Sure, I will give it a try, probably later today.
|
christiankaindl
added a commit
to christiankaindl/virtual
that referenced
this pull request
Aug 3, 2022
|
Created a PR for the build issue -> #361 |
tannerlinsley
pushed a commit
that referenced
this pull request
Aug 3, 2022
christiankaindl
added a commit
to christiankaindl/react-charts
that referenced
this pull request
Aug 3, 2022
tannerlinsley
pushed a commit
to TanStack/react-charts
that referenced
this pull request
Aug 3, 2022
devlancer-lucas
added a commit
to devlancer-lucas/react-charts
that referenced
this pull request
Mar 17, 2023
AwfulDarkness0110
added a commit
to AwfulDarkness0110/react-charts
that referenced
this pull request
Jun 28, 2023
acestar121
added a commit
to acestar121/react-charts
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces idle CPU usage and should also improve scrolling performance. The previous approach used a
requestAnimationFrame()loop with calls togetBoundingClientRect()on every frame.Fixes #359
Before
After (+ dark mode 馃槃):
Verified it still works, the number of items increase and decrease when resizing:
Screen.Recording.2022-08-03.at.00.53.53.mov