feat: detect scroll completion with scrollend event #707
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 757dd10. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
piecyk
changed the title
| passive: true, | ||
| }) | ||
| element.addEventListener('scroll', handler, addEventListenerOptions) | ||
| element.addEventListener('scrollend', endHandler, addEventListenerOptions) |
There was a problem hiding this comment.
Does it makes sense to add event listener even though browser won't support it 🤔
There was a problem hiding this comment.
It will be no op, overall wrapping it with if in two places don't really change anything
|
|
||
| return () => { | ||
| element.removeEventListener('resize', handler) | ||
| } | ||
| } | ||
|
|
||
| const supportsScrollend = | ||
| typeof window == 'undefined' ? true : 'onscrollend' in window |
There was a problem hiding this comment.
just wondering why true in case of missing window 🤔
There was a problem hiding this comment.
As in non window scrollend should be handled by caller, we don't want to create this fallback as it's only for browser environment.
piecyk
force-pushed
the
feat/use-scrollend
branch
from
8a91aea
to
757dd10
Compare
As scrollend event is supported by almost all major browser ( without safari ) we can use it to detect scroll completion, in this change the observeElementOffset type signature changed, current it will be not only responsible to return scroll offset but also if is scrolling.
https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollend_event
https://developer.chrome.com/blog/scrollend-a-new-javascript-event/