Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Tangerine upgrade, environment variables not being updated causes bad links #114

Closed
rjcorwin opened this issue Aug 2, 2016 · 3 comments
Closed

On Tangerine upgrade, environment variables not being updated causes bad links #114

rjcorwin opened this issue Aug 2, 2016 · 3 comments
Assignees
@rjcorwin
Labels
bug

Comments

@rjcorwin
Copy link
Contributor

rjcorwin commented Aug 2, 2016 •
edited
Loading

If you change T_HOST_NAME and/or T_PROTOCOL, these will not be updated in group's corresponding settings files' groupHost and/orhostname properties.

As an MVP solution for this, on Robbert starting, Robbert could update the properties in group settings docs specific to environment variables.
rjcorwin added a commit that referenced this issue Aug 2, 2016
@rjcorwin
#114 #113 Place a notice in README that you cannot safely update envi…
8c69013 
…ronment variables between updates
@rjcorwin rjcorwin mentioned this issue Aug 2, 2016
Closed
@rjcorwin rjcorwin added this to the Tangerine 1.0.0 milestone Aug 18, 2016
rjcorwin added a commit that referenced this issue Aug 30, 2016
@rjcorwin
#114 Allow the configuration doc to override the settings doc in client
7233c46
@rjcorwin rjcorwin self-assigned this Aug 30, 2016
@rjcorwin
Copy link
Contributor Author

This PR has a potential way forward. #152

@rjcorwin rjcorwin added ready and removed in progress labels Sep 6, 2016
@mfinholt mfinholt mentioned this issue Oct 3, 2016
Closed
@rjcorwin rjcorwin removed the ready label Dec 19, 2016
@mfinholt mfinholt added v2.x.x and removed v2.x.x labels Jan 20, 2017
@rjcorwin rjcorwin modified the milestone: Tangerine 1.0.0 Mar 2, 2017
@rjcorwin rjcorwin changed the title Move all Environment based properties of tangerine/settings to tangerine/configuration On Tangerine upgrade, environment variables not being updated causes bad links Mar 2, 2017
@rjcorwin rjcorwin added the bug label Mar 2, 2017
@rjcorwin rjcorwin mentioned this issue Mar 21, 2017
Closed
5 tasks
@rjcorwin
Copy link
Contributor Author

A potential technical solution has been proposed here here #249

@rjcorwin
Copy link
Contributor Author

rjcorwin commented Oct 3, 2017

This has been solved using the tangerine deploy-globals script.

@rjcorwin rjcorwin closed this as completed Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjcorwin rjcorwin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjcorwin @mfinholt