Allow element rendered by Provider to be configured #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default `<div>` wrapper isn't valid anywhere in the DOM. By allowing the wrapper element to be configured it is possible for the user to change it to something else when needed. An example use case for this are component libraries with bundled translations. If a component is intended to be used as phrasing content then it can't introduce a `<div>`. Moving the `Provider` higher up the tree isn't possible here, as this falls out of the scope of the library.
|
(merged via another branch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
<div>wrapper isn't valid anywhere in the DOM. By allowingthe wrapper element to be configured it is possible for the user to
change it to something else when needed.
An example use case for this are component libraries with bundled
translations. If a component is intended to be used as phrasing content
then it can't introduce a
<div>. Moving theProviderhigher upthe tree isn't possible here, as this falls out of the scope of the
library.