-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing adduser on the docker image ubuntu:latest. #145
Fix missing adduser on the docker image ubuntu:latest. #145
Conversation
I'm getting some errors while building it in docker container
|
I can't reproduce it here. My environment is as follows:
|
I was able fix that error by doing: -USER user
-WORKDIR /home/user
+WORKDIR /home/user
+USER user I was able to run it. After running more errors: $ sudo docker run --rm -v $PROCFETCH:/procfetch -w /procfetch procfetch make run
make -C src -j run
make[1]: Entering directory '/procfetch/src'
./procfetch
terminate called after throwing an instance of 'std::logic_error'
what(): basic_string: construction from null is not valid
make[1]: Leaving directory '/procfetch/src'
make[1]: *** [Makefile:16: run] Aborted (core dumped)
make: *** [Makefile:12: src] Error 2 I'll try to debug this during night. |
That change in the If I set a value to the $ USER=$(whoami) src/procfetch |
Yupp, It does! |
I’ve updated this PR with both changes. Check it. Well. In the Docker container environment that we provide, it is acceptable to set the However, as this case shows, it is incorrect to assume that the environment variable |
Definitely, we've got a bunch of cases causing the program to halt. I'll create a separate issue for those, then we can start fixing them. As for getting the username, we could just use the |
Anyways, I'm merging this PR! |
The docker image
ubuntu:latest
has been changed to 24.04 LTS.The new image does not install the
adduser
command by default, which causes errors when building the docker imageprocfetch
.This pull request contains changes to the
Dockerfile
.Related Issue(s)
This pull request fixes the issue #146.