Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot improvements and fixes #204

Merged
merged 1 commit into from
Dec 24, 2023
Merged

plot improvements and fixes #204

merged 1 commit into from
Dec 24, 2023

Conversation

Tantalor93
Copy link
Owner

new features and changes:

  • svg plot format is now supported and is the new default
  • improved readability of all line plot plots by overlaying scatter plot more clearly

fixes:

  • line graphs are now properly relative to the start of the benchmark

breaking changes in public interfaces:

  • Datapoint.Duration is now time.Duration
  • Benchmark.PrintReport now also accepts the time when Benchmark started

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (62e8d35) 79.38% compared to head (1a38651) 79.44%.

Files Patch % Lines
cmd/plot.go 87.30% 4 Missing and 4 partials ⚠️
cmd/report.go 57.14% 3 Missing ⚠️
cmd/root.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   79.38%   79.44%   +0.05%     
==========================================
  Files           7        7              
  Lines        1140     1143       +3     
==========================================
+ Hits          905      908       +3     
  Misses        189      189              
  Partials       46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tantalor93 Tantalor93 merged commit 24e11c7 into master Dec 24, 2023
6 checks passed
@Tantalor93 Tantalor93 deleted the plotfix branch December 24, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant