Support/aws bedrock #120
Merged
Support/aws bedrock #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd added claude2 support, wip
…tion parameters, possibility to change teacher model
JackHopkins
requested changes
Jan 15, 2024
| LLM_GENERATION_PARAMETERS = ["temperature", "top_p", "max_new_tokens"] | ||
|
|
||
|
|
||
| class LLama_Bedrock_API(Bedrock_API): |
There was a problem hiding this comment.
Strange capitalization.
| from tanuki.language_models.llm_configs.openai_config import OpenAIConfig | ||
| from tanuki.language_models.llm_configs.claude_config import ClaudeConfig | ||
| from tanuki.language_models.llm_configs.llama_config import LlamaBedrockConfig | ||
| DEFAULT_MODELS = { |
There was a problem hiding this comment.
So I suggest this goes to init.py
| return input_config | ||
| if isinstance(input_config, str): | ||
| # This is purely for backwards compatibility as we used to save the model as a string | ||
| if type == "distillation": |
There was a problem hiding this comment.
"distillation" -> into a DISTILLATION constant.
src/tanuki/function_modeler.py
Outdated
|
|
||
| def _get_dataset_info(self, dataset_type, func_hash, type="length"): | ||
| """ | ||
| Get the dataset size for a function hash | ||
| """ | ||
| return self.data_worker.load_dataset(dataset_type, func_hash, return_type=type) | ||
|
|
||
| def _configure_teacher_models(self, teacher_models: list, func_hash: str): |
There was a problem hiding this comment.
Please include more expressive type definition.
src/tanuki/models/api_manager.py
Outdated
| """ | ||
| Adds an API provider to the API manager. | ||
| """ | ||
| if provider =="openai": |
There was a problem hiding this comment.
Replace with constant.
| """ | ||
| distilled_model: BaseModelConfig = DEFAULT_MODELS["gpt-3.5-finetune"] | ||
| current_model_stats : Dict = { | ||
| "trained_on_datapoints": 0, |
| "anthropic.claude-v2:1": ClaudeConfig(model_name = "anthropic.claude-v2:1", context_length = 200000), | ||
| "llama_70b_chat_aws": LlamaBedrockConfig(model_name = "meta.llama2-70b-chat-v1", context_length = 4096), | ||
| "llama_13b_chat_aws": LlamaBedrockConfig(model_name = "meta.llama2-13b-chat-v1", context_length = 4096), | ||
| "ada-002": OpenAIConfig(model_name="text-embedding-ada-002", context_length=-1) |
There was a problem hiding this comment.
Lets add at least 1 bedrock embedding model.
JackHopkins
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing support for Bedrock and LLama models through bedrock as the teacher models
Main changes