-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.2.5] Proguard is not working #17
Comments
Maybe the reason is one of two: If you have an older installation on your phone(with a debug key), please uninstall it first. (You can't have the same app with two different signatures on your device) Assuming you're keeping ADT up to date. If you are using ant release, it will load the Proguard settings from the file specified by the proguard.config property in ant.properties. That being said, are you getting any kind of errors or warnings during your build? These are especially helpful when diagnosing Proguard since it's purpose is to remove classes and methods that it doesn't think are being used by your application. |
The key to fixing the build is looking at the build output messages, understanding what the warnings are about and addressing them, usually by fixing your dependencies or adding -dontwarn rules to your ProGuard config. You can refer to https://medium.com/androiddevelopers/troubleshooting-proguard-issues-on-android-bce9de4f8a74 |
You have problems in TAP-GLKIt android dependency, I think it's using reflection. You should define these rules in the sdk documentation, I think it's not a application issue. If you run my sample application you will see a crash. |
Have you defined these rules? I think this shouldn't be closed until the library defines the rules Here you can see an example of one of the biggest library on android |
I did, But it will be available in the next release.
Next release will expose an API to get list of saved cards for current
customer.
*Sincerely,*
*Haitham Elsheshtawy*
*http://about.me/Haitham.Sheshtawy <http://about.me/Haitham.Sheshtawy>*
…On Mon, Jun 24, 2019 at 5:15 PM Matías Irland ***@***.***> wrote:
Have you defined these rules? I think this shouldn't be closed until the
library defines the rules Here you can see an example of one of the biggest
library on android <https://github.com/square/okhttp/#r8--proguard>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#17?email_source=notifications&email_token=ABTCNPFP5M52LMV63D6CVADP4DJHPA5CNFSM4HOV5MA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYNCDJY#issuecomment-505029031>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABTCNPCP4RWSHIWL23WCV63P4DJHPANCNFSM4HOV5MAQ>
.
|
this is not fixed, so it should be reopened, please test it. I added the solution in #21 |
The sdk doesn't work if Proguard is enabled, you can take a look at xmartlabs@0325ee7
The text was updated successfully, but these errors were encountered: