Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set color / fontsize dynamically #228

Closed
dosomder opened this issue Jun 22, 2020 · 5 comments · Fixed by #232
Closed

Set color / fontsize dynamically #228

dosomder opened this issue Jun 22, 2020 · 5 comments · Fixed by #232

Comments

@dosomder
Copy link
Contributor

In previous version it was possible to access the text / title directly by getTitle() and getText(). You could then call for example setTextSize() or setTextColor() directly.

Now this is not possible anymore and you can only change the appearance by using a style resource with setTextAppearance(). However, I need to set the color dynamically. @kpmmmurphy would you accept a PR to add these getters back?

@dosomder
Copy link
Contributor Author

@kpmmmurphy Anything against a PR?

@kpmmmurphy
Copy link
Collaborator

Hey @dosomder, PRs always welcome!

@bellalMohamed
Copy link

bellalMohamed commented Jun 26, 2020

Hello, @dosomder

Is there any intention to make a PR anytime soon to add these getters back?

@dosomder
Copy link
Contributor Author

@bellalMohamed yes I plan to do a PR in the coming week. Are you interested in this feature as well?

@bellalMohamed
Copy link

@dosomder I see you already replied to the issue on NativeScript feedback plugin which is a wrapper around this plugin 😅😅

dosomder added a commit to dosomder/Alerter that referenced this issue Jun 27, 2020
Allows to change TextView properties dynamically. Fixes Tapadoo#228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants