Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerter can be appear from bottom or center #212

Merged
merged 4 commits into from
Jan 28, 2020
Merged

Alerter can be appear from bottom or center #212

merged 4 commits into from
Jan 28, 2020

Conversation

rezaiyan
Copy link
Contributor

@rezaiyan rezaiyan commented Jan 28, 2020 •
edited

@rezaiyan rezaiyan mentioned this pull request Jan 28, 2020
Open
@kpmmmurphy
Copy link
Collaborator

Hey @rezaiyan, thanks for your PR! Looks good, one last step is to update the version in the build.gradle, and the changelog! Then we're good to merge 🚀

@kpmmmurphy kpmmmurphy merged commit 0a49acc into Tapadoo:develop Jan 28, 2020
@dosomder
Copy link
Contributor

dosomder commented Jun 1, 2020 •
edited

@rezaiyan I have an issue when showing the alerter at the bottom. Looks like alert is moved to the left.
Any idea what the problem is? I suppose it has something to do with the padding you set when not using Gravity.TOP

grafik

@rezaiyan
Copy link
Contributor Author

rezaiyan commented Jun 2, 2020 •
edited

@rezaiyan I have an issue when showing the alerter at the bottom. Looks like alert is moved to the left.
Any idea what the problem is? I suppose it has something to do with the padding you set when not using Gravity.TOP

Yeah, It seems has no padding on left side
I'll fix it.

@dosomder
Copy link
Contributor

dosomder commented Jun 2, 2020

Thanks @rezaiyan
Also I think the notch height can be disregarded when not using TOP, right?

@rezaiyan
Copy link
Contributor Author

rezaiyan commented Jun 2, 2020

Thanks @rezaiyan
Also I think the notch height can be disregarded when not using TOP, right?

Yes, but if the notch height being removed, the extra padding of the bottom must be removed too, then it makes the Alerter thin.

@rezaiyan rezaiyan mentioned this pull request Jun 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rezaiyan @kpmmmurphy @dosomder