Enable\disable alert click animation #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpmmmurphy
requested changes
Aug 21, 2020
|
Looks all good @TalbotGooday, before we merge, please update the version in the build.gradle, and the change log - and we're good to go! Thanks again. |
|
@kpmmmurphy Do you want to release a new version with this request? I thought it would just end up in the code with some larger update) And another question, if you don't mind: why is the Alert.hide() method is private? Are there any bugs with the hide() method? |
|
@TalbotGooday I think so, otherwise it may site here for some time! Please bump it to 6.2.0! That method is private, as we want to force the use of |
|
@kpmmmurphy I got it. Thank you) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oddly enough, this functionality turned out to be very important when it became necessary to create an alert whose width is less than the width of the screen.
Issue: #226